From 45e671966a5dd5edec93dc0b788db140481c1388 Mon Sep 17 00:00:00 2001 From: Frontend Developer Date: Sun, 5 Jul 2026 14:09:49 +0800 Subject: [PATCH] feat: complete frontend ui integrity followups --- .github/workflows/ci.yml | 10 + .workbuddy/memory/2026-07-03.md | 39 + Dockerfile.poster | 28 + REVIEW_REPORT_SPRINT_1_TO_4_2026-07-03.md | 191 +++++ SPRINT_4_CLOSEOUT_2026-07-03_SUPERSEDED.md | 146 ++++ SPRINT_4_PROGRESS_2026-07-03.md | 59 +- SPRINT_5_PROGRESS_2026-07-04.md | 87 ++ SPRINT_6_PROGRESS_2026-07-04.md | 59 ++ SPRINT_7_PROGRESS_2026-07-04.md | 138 ++++ admin/routes/sprint3_api.py | 49 +- admin/tests/test_sprint3_api_contract.py | 10 +- apps/web/e2e/admin-portal.spec.ts | 194 +++++ apps/web/e2e/poster-generate-download.spec.ts | 61 +- apps/web/e2e/runtime-accessibility.spec.ts | 76 ++ apps/web/package.json | 1 + .../src/components/AccessTrendChart.test.tsx | 25 +- apps/web/src/components/AccessTrendChart.tsx | 16 +- .../src/components/AuditReportCard.test.tsx | 50 ++ apps/web/src/components/AuditReportCard.tsx | 60 +- apps/web/src/components/CareerCard.test.tsx | 45 ++ apps/web/src/components/CareerCard.tsx | 49 +- apps/web/src/components/ChatMessage.test.tsx | 36 + apps/web/src/components/ChatMessage.tsx | 20 +- .../web/src/components/DataQueryForm.test.tsx | 81 ++ apps/web/src/components/DataQueryForm.tsx | 187 +++++ .../src/components/DataQueryResult.test.tsx | 107 +++ apps/web/src/components/DataQueryResult.tsx | 153 ++++ .../src/components/FileUploadPrompt.test.tsx | 24 + apps/web/src/components/FileUploadPrompt.tsx | 33 +- apps/web/src/components/FormCard.test.tsx | 10 +- apps/web/src/components/FormCard.tsx | 174 ++-- .../src/components/LLMEnhancement.test.tsx | 160 ++++ apps/web/src/components/LLMEnhancement.tsx | 155 ++++ apps/web/src/components/PlanCard.test.tsx | 77 ++ apps/web/src/components/PlanCard.tsx | 78 +- .../web/src/components/PosterPreview.test.tsx | 195 +++++ apps/web/src/components/PosterPreview.tsx | 153 ++++ apps/web/src/components/ReviewFlow.test.tsx | 260 ++++++ apps/web/src/components/ReviewFlow.tsx | 183 +++++ apps/web/src/components/ShareDialog.test.tsx | 16 + apps/web/src/components/ShareDialog.tsx | 151 +--- apps/web/src/components/SharePanel.test.tsx | 55 ++ apps/web/src/components/SharePanel.tsx | 153 ++++ .../src/components/ShareStatusPanel.test.tsx | 56 ++ apps/web/src/components/ShareStatusPanel.tsx | 89 +++ apps/web/src/components/StatsCard.test.tsx | 17 + apps/web/src/components/StatsCard.tsx | 37 +- apps/web/src/components/UploadBar.test.tsx | 37 + apps/web/src/components/UploadBar.tsx | 49 +- .../src/components/admin/RequireAuth.test.tsx | 59 ++ apps/web/src/components/admin/RequireAuth.tsx | 24 + .../components/navigation/MobileNav.test.tsx | 37 + .../src/components/navigation/MobileNav.tsx | 27 +- .../navigation/ModeIndicator.test.tsx | 32 +- .../components/navigation/ModeIndicator.tsx | 29 +- .../components/navigation/Sidebar.test.tsx | 63 ++ .../web/src/components/navigation/Sidebar.tsx | 70 +- .../src/components/shared/Accordion.test.tsx | 42 + apps/web/src/components/shared/Accordion.tsx | 56 ++ .../web/src/components/shared/Avatar.test.tsx | 25 + apps/web/src/components/shared/Avatar.tsx | 39 + .../web/src/components/shared/Charts.test.tsx | 51 ++ apps/web/src/components/shared/Charts.tsx | 112 +++ .../src/components/shared/DataTable.test.tsx | 59 ++ apps/web/src/components/shared/DataTable.tsx | 113 +++ .../src/components/shared/DatePicker.test.tsx | 31 + apps/web/src/components/shared/DatePicker.tsx | 35 + .../src/components/shared/Dropdown.test.tsx | 43 + apps/web/src/components/shared/Dropdown.tsx | 78 ++ .../src/components/shared/EmptyState.test.tsx | 27 + apps/web/src/components/shared/EmptyState.tsx | 31 + .../components/shared/ErrorFallback.test.tsx | 29 + .../src/components/shared/ErrorFallback.tsx | 26 +- .../components/shared/LocaleSwitcher.test.tsx | 23 + .../src/components/shared/LocaleSwitcher.tsx | 27 + apps/web/src/components/shared/Modal.test.tsx | 66 ++ apps/web/src/components/shared/Modal.tsx | 78 ++ .../components/shared/OfflineBanner.test.tsx | 17 +- .../src/components/shared/OfflineBanner.tsx | 6 +- .../src/components/shared/Pagination.test.tsx | 44 ++ apps/web/src/components/shared/Pagination.tsx | 54 ++ .../src/components/shared/ProgressSteps.tsx | 42 +- .../components/shared/RouteFallback.test.tsx | 23 + .../src/components/shared/RouteFallback.tsx | 23 +- .../src/components/shared/SafeMarkdown.tsx | 30 +- .../web/src/components/shared/Select.test.tsx | 36 + apps/web/src/components/shared/Select.tsx | 46 ++ .../src/components/shared/Skeleton.test.tsx | 33 + apps/web/src/components/shared/Skeleton.tsx | 32 + .../src/components/shared/Stepper.test.tsx | 48 ++ apps/web/src/components/shared/Stepper.tsx | 69 ++ .../components/shared/SubmitButton.test.tsx | 13 +- .../src/components/shared/SubmitButton.tsx | 15 +- .../components/shared/ThemeToggle.test.tsx | 32 + .../web/src/components/shared/ThemeToggle.tsx | 30 +- apps/web/src/components/shared/Toast.test.tsx | 61 ++ apps/web/src/components/shared/Toast.tsx | 82 ++ .../src/components/shared/Tooltip.test.tsx | 20 + apps/web/src/components/shared/Tooltip.tsx | 26 + apps/web/src/components/shared/Tree.test.tsx | 61 ++ apps/web/src/components/shared/Tree.tsx | 87 ++ .../components/shared/keyboardA11y.test.tsx | 61 ++ apps/web/src/hooks/index.ts | 14 +- apps/web/src/hooks/useAdminCases.ts | 74 ++ apps/web/src/hooks/useAdminOrders.ts | 106 +++ apps/web/src/hooks/useAdminPosters.ts | 85 ++ apps/web/src/hooks/useAdminShareLinks.ts | 159 ++++ apps/web/src/hooks/useAssessmentMutations.ts | 6 +- apps/web/src/hooks/useAuditMutations.ts | 6 +- apps/web/src/hooks/useChatMutations.ts | 25 +- apps/web/src/hooks/useChatOrchestrator.ts | 13 +- apps/web/src/hooks/useChatQueries.ts | 6 +- .../web/src/hooks/useConsultationMutations.ts | 6 +- apps/web/src/hooks/useConsultationQueries.ts | 6 +- apps/web/src/hooks/useLLMEnhanceMutation.ts | 2 +- apps/web/src/hooks/usePlanMutations.ts | 6 +- apps/web/src/hooks/usePlanQueries.ts | 6 +- apps/web/src/hooks/usePortal.ts | 4 +- apps/web/src/hooks/usePosterGenerate.test.tsx | 44 ++ apps/web/src/hooks/usePosterGenerate.ts | 47 +- apps/web/src/hooks/usePrefetchLazyRoute.ts | 22 +- apps/web/src/hooks/useScrollRecovery.ts | 8 +- apps/web/src/hooks/useShareLink.ts | 2 +- apps/web/src/hooks/useUploadMutations.ts | 8 +- apps/web/src/i18n/AppIntlProvider.tsx | 18 + apps/web/src/i18n/messages.ts | 16 + apps/web/src/i18n/messages/en-US.json | 744 ++++++++++++++++++ apps/web/src/i18n/messages/zh-CN.json | 744 ++++++++++++++++++ apps/web/src/layouts/AdminLayout.test.tsx | 63 ++ apps/web/src/layouts/AdminLayout.tsx | 117 +++ apps/web/src/layouts/AppLayout.test.tsx | 23 +- apps/web/src/layouts/AppLayout.tsx | 21 +- apps/web/src/lib/api-client.ts | 12 +- apps/web/src/lib/api-schemas.ts | 8 +- apps/web/src/lib/llm/provider.ts | 22 +- apps/web/src/main.tsx | 15 +- apps/web/src/pages/AboutPage.test.tsx | 41 + apps/web/src/pages/AboutPage.tsx | 112 ++- apps/web/src/pages/ConsultationsPage.test.tsx | 137 ++++ apps/web/src/pages/ConsultationsPage.tsx | 89 ++- apps/web/src/pages/DataQueryPage.test.tsx | 142 ++++ apps/web/src/pages/DataQueryPage.tsx | 232 +++--- apps/web/src/pages/HomePage.test.tsx | 52 +- apps/web/src/pages/HomePage.tsx | 183 +++-- apps/web/src/pages/NotFoundPage.test.tsx | 26 + apps/web/src/pages/NotFoundPage.tsx | 12 +- apps/web/src/pages/PlanComparePage.test.tsx | 67 ++ apps/web/src/pages/PlanComparePage.tsx | 71 +- apps/web/src/pages/PlanDetailPage.test.tsx | 89 +++ apps/web/src/pages/PlanDetailPage.tsx | 45 +- apps/web/src/pages/PlansPage.test.tsx | 108 +++ apps/web/src/pages/PlansPage.tsx | 60 +- apps/web/src/pages/PortalPage.test.tsx | 127 +++ apps/web/src/pages/PortalPage.tsx | 129 ++- apps/web/src/pages/PosterPreviewPage.test.tsx | 143 ++++ apps/web/src/pages/PosterPreviewPage.tsx | 119 +-- apps/web/src/pages/ReviewPage.test.tsx | 111 ++- apps/web/src/pages/ReviewPage.tsx | 148 +--- apps/web/src/pages/ShareDialogPage.test.tsx | 18 +- apps/web/src/pages/ShareDialogPage.tsx | 69 +- .../src/pages/admin/CaseDetailPage.test.tsx | 52 ++ apps/web/src/pages/admin/CaseDetailPage.tsx | 122 +++ apps/web/src/pages/admin/CasesPage.test.tsx | 41 + apps/web/src/pages/admin/CasesPage.tsx | 155 ++++ .../src/pages/admin/DashboardPage.test.tsx | 25 + apps/web/src/pages/admin/DashboardPage.tsx | 103 +++ apps/web/src/pages/admin/ErrorPage.test.tsx | 25 + apps/web/src/pages/admin/ErrorPage.tsx | 86 ++ apps/web/src/pages/admin/ForbiddenPage.tsx | 21 + apps/web/src/pages/admin/LoginPage.test.tsx | 62 ++ apps/web/src/pages/admin/LoginPage.tsx | 170 ++++ apps/web/src/pages/admin/MajorsPage.test.tsx | 34 + apps/web/src/pages/admin/MajorsPage.tsx | 112 +++ .../src/pages/admin/OrderDetailPage.test.tsx | 58 ++ apps/web/src/pages/admin/OrderDetailPage.tsx | 165 ++++ apps/web/src/pages/admin/OrdersPage.test.tsx | 40 + apps/web/src/pages/admin/OrdersPage.tsx | 185 +++++ apps/web/src/pages/admin/PostersPage.test.tsx | 35 + apps/web/src/pages/admin/PostersPage.tsx | 180 +++++ .../pages/admin/RankEstimatorPage.test.tsx | 28 + .../web/src/pages/admin/RankEstimatorPage.tsx | 56 ++ apps/web/src/pages/admin/SchoolsPage.test.tsx | 35 + apps/web/src/pages/admin/SchoolsPage.tsx | 146 ++++ .../src/pages/admin/ScoreLinesPage.test.tsx | 29 + apps/web/src/pages/admin/ScoreLinesPage.tsx | 55 ++ .../pages/admin/ShareLinkDetailPage.test.tsx | 56 ++ .../src/pages/admin/ShareLinkDetailPage.tsx | 145 ++++ .../src/pages/admin/ShareLinksPage.test.tsx | 34 + apps/web/src/pages/admin/ShareLinksPage.tsx | 184 +++++ .../web/src/quality/adminA11yCoverage.test.ts | 55 ++ apps/web/src/quality/darkModeCoverage.test.ts | 24 + .../src/quality/i18nMessagesCoverage.test.ts | 100 +++ apps/web/src/quality/noAlertUsage.test.ts | 34 + apps/web/src/router.tsx | 59 +- apps/web/src/schemas/api-generated.ts | 45 +- apps/web/src/stores/chat.ts | 17 +- apps/web/src/stores/form.ts | 12 +- apps/web/src/stores/index.ts | 10 +- apps/web/src/stores/stores.test.ts | 33 +- apps/web/src/stores/ui.ts | 22 +- apps/web/src/stores/user.ts | 12 +- apps/web/src/test/mocks/handlers.ts | 410 ++++++++++ apps/web/src/test/renderWithProviders.tsx | 17 +- apps/web/src/types/api-generated.d.ts | 87 +- apps/web/src/types/domain.ts | 8 +- apps/web/src/types/message.ts | 18 +- apps/web/vite.config.ts | 13 +- docker-compose.yml | 11 + pnpm-lock.yaml | 61 ++ reports/sprint4-real-backend-regression.json | 37 + tests/integration/__init__.py | 1 + .../test_sprint4_integration_suite.py | 49 ++ tests/test_poster_cli_docker_contract.py | 37 + 213 files changed, 13517 insertions(+), 1344 deletions(-) create mode 100644 Dockerfile.poster create mode 100644 REVIEW_REPORT_SPRINT_1_TO_4_2026-07-03.md create mode 100644 SPRINT_4_CLOSEOUT_2026-07-03_SUPERSEDED.md create mode 100644 SPRINT_5_PROGRESS_2026-07-04.md create mode 100644 SPRINT_6_PROGRESS_2026-07-04.md create mode 100644 SPRINT_7_PROGRESS_2026-07-04.md create mode 100644 apps/web/e2e/admin-portal.spec.ts create mode 100644 apps/web/e2e/runtime-accessibility.spec.ts create mode 100644 apps/web/src/components/AuditReportCard.test.tsx create mode 100644 apps/web/src/components/CareerCard.test.tsx create mode 100644 apps/web/src/components/ChatMessage.test.tsx create mode 100644 apps/web/src/components/DataQueryForm.test.tsx create mode 100644 apps/web/src/components/DataQueryForm.tsx create mode 100644 apps/web/src/components/DataQueryResult.test.tsx create mode 100644 apps/web/src/components/DataQueryResult.tsx create mode 100644 apps/web/src/components/FileUploadPrompt.test.tsx create mode 100644 apps/web/src/components/LLMEnhancement.test.tsx create mode 100644 apps/web/src/components/LLMEnhancement.tsx create mode 100644 apps/web/src/components/PlanCard.test.tsx create mode 100644 apps/web/src/components/PosterPreview.test.tsx create mode 100644 apps/web/src/components/PosterPreview.tsx create mode 100644 apps/web/src/components/ReviewFlow.test.tsx create mode 100644 apps/web/src/components/ReviewFlow.tsx create mode 100644 apps/web/src/components/SharePanel.test.tsx create mode 100644 apps/web/src/components/SharePanel.tsx create mode 100644 apps/web/src/components/ShareStatusPanel.test.tsx create mode 100644 apps/web/src/components/ShareStatusPanel.tsx create mode 100644 apps/web/src/components/UploadBar.test.tsx create mode 100644 apps/web/src/components/admin/RequireAuth.test.tsx create mode 100644 apps/web/src/components/admin/RequireAuth.tsx create mode 100644 apps/web/src/components/navigation/MobileNav.test.tsx create mode 100644 apps/web/src/components/navigation/Sidebar.test.tsx create mode 100644 apps/web/src/components/shared/Accordion.test.tsx create mode 100644 apps/web/src/components/shared/Accordion.tsx create mode 100644 apps/web/src/components/shared/Avatar.test.tsx create mode 100644 apps/web/src/components/shared/Avatar.tsx create mode 100644 apps/web/src/components/shared/Charts.test.tsx create mode 100644 apps/web/src/components/shared/Charts.tsx create mode 100644 apps/web/src/components/shared/DataTable.test.tsx create mode 100644 apps/web/src/components/shared/DataTable.tsx create mode 100644 apps/web/src/components/shared/DatePicker.test.tsx create mode 100644 apps/web/src/components/shared/DatePicker.tsx create mode 100644 apps/web/src/components/shared/Dropdown.test.tsx create mode 100644 apps/web/src/components/shared/Dropdown.tsx create mode 100644 apps/web/src/components/shared/EmptyState.test.tsx create mode 100644 apps/web/src/components/shared/EmptyState.tsx create mode 100644 apps/web/src/components/shared/ErrorFallback.test.tsx create mode 100644 apps/web/src/components/shared/LocaleSwitcher.test.tsx create mode 100644 apps/web/src/components/shared/LocaleSwitcher.tsx create mode 100644 apps/web/src/components/shared/Modal.test.tsx create mode 100644 apps/web/src/components/shared/Modal.tsx create mode 100644 apps/web/src/components/shared/Pagination.test.tsx create mode 100644 apps/web/src/components/shared/Pagination.tsx create mode 100644 apps/web/src/components/shared/RouteFallback.test.tsx create mode 100644 apps/web/src/components/shared/Select.test.tsx create mode 100644 apps/web/src/components/shared/Select.tsx create mode 100644 apps/web/src/components/shared/Skeleton.test.tsx create mode 100644 apps/web/src/components/shared/Skeleton.tsx create mode 100644 apps/web/src/components/shared/Stepper.test.tsx create mode 100644 apps/web/src/components/shared/Stepper.tsx create mode 100644 apps/web/src/components/shared/ThemeToggle.test.tsx create mode 100644 apps/web/src/components/shared/Toast.test.tsx create mode 100644 apps/web/src/components/shared/Toast.tsx create mode 100644 apps/web/src/components/shared/Tooltip.test.tsx create mode 100644 apps/web/src/components/shared/Tooltip.tsx create mode 100644 apps/web/src/components/shared/Tree.test.tsx create mode 100644 apps/web/src/components/shared/Tree.tsx create mode 100644 apps/web/src/components/shared/keyboardA11y.test.tsx create mode 100644 apps/web/src/hooks/useAdminCases.ts create mode 100644 apps/web/src/hooks/useAdminOrders.ts create mode 100644 apps/web/src/hooks/useAdminPosters.ts create mode 100644 apps/web/src/hooks/useAdminShareLinks.ts create mode 100644 apps/web/src/hooks/usePosterGenerate.test.tsx create mode 100644 apps/web/src/i18n/AppIntlProvider.tsx create mode 100644 apps/web/src/i18n/messages.ts create mode 100644 apps/web/src/i18n/messages/en-US.json create mode 100644 apps/web/src/i18n/messages/zh-CN.json create mode 100644 apps/web/src/layouts/AdminLayout.test.tsx create mode 100644 apps/web/src/layouts/AdminLayout.tsx create mode 100644 apps/web/src/pages/AboutPage.test.tsx create mode 100644 apps/web/src/pages/ConsultationsPage.test.tsx create mode 100644 apps/web/src/pages/DataQueryPage.test.tsx create mode 100644 apps/web/src/pages/NotFoundPage.test.tsx create mode 100644 apps/web/src/pages/PlanComparePage.test.tsx create mode 100644 apps/web/src/pages/PlanDetailPage.test.tsx create mode 100644 apps/web/src/pages/PlansPage.test.tsx create mode 100644 apps/web/src/pages/PortalPage.test.tsx create mode 100644 apps/web/src/pages/PosterPreviewPage.test.tsx create mode 100644 apps/web/src/pages/admin/CaseDetailPage.test.tsx create mode 100644 apps/web/src/pages/admin/CaseDetailPage.tsx create mode 100644 apps/web/src/pages/admin/CasesPage.test.tsx create mode 100644 apps/web/src/pages/admin/CasesPage.tsx create mode 100644 apps/web/src/pages/admin/DashboardPage.test.tsx create mode 100644 apps/web/src/pages/admin/DashboardPage.tsx create mode 100644 apps/web/src/pages/admin/ErrorPage.test.tsx create mode 100644 apps/web/src/pages/admin/ErrorPage.tsx create mode 100644 apps/web/src/pages/admin/ForbiddenPage.tsx create mode 100644 apps/web/src/pages/admin/LoginPage.test.tsx create mode 100644 apps/web/src/pages/admin/LoginPage.tsx create mode 100644 apps/web/src/pages/admin/MajorsPage.test.tsx create mode 100644 apps/web/src/pages/admin/MajorsPage.tsx create mode 100644 apps/web/src/pages/admin/OrderDetailPage.test.tsx create mode 100644 apps/web/src/pages/admin/OrderDetailPage.tsx create mode 100644 apps/web/src/pages/admin/OrdersPage.test.tsx create mode 100644 apps/web/src/pages/admin/OrdersPage.tsx create mode 100644 apps/web/src/pages/admin/PostersPage.test.tsx create mode 100644 apps/web/src/pages/admin/PostersPage.tsx create mode 100644 apps/web/src/pages/admin/RankEstimatorPage.test.tsx create mode 100644 apps/web/src/pages/admin/RankEstimatorPage.tsx create mode 100644 apps/web/src/pages/admin/SchoolsPage.test.tsx create mode 100644 apps/web/src/pages/admin/SchoolsPage.tsx create mode 100644 apps/web/src/pages/admin/ScoreLinesPage.test.tsx create mode 100644 apps/web/src/pages/admin/ScoreLinesPage.tsx create mode 100644 apps/web/src/pages/admin/ShareLinkDetailPage.test.tsx create mode 100644 apps/web/src/pages/admin/ShareLinkDetailPage.tsx create mode 100644 apps/web/src/pages/admin/ShareLinksPage.test.tsx create mode 100644 apps/web/src/pages/admin/ShareLinksPage.tsx create mode 100644 apps/web/src/quality/adminA11yCoverage.test.ts create mode 100644 apps/web/src/quality/darkModeCoverage.test.ts create mode 100644 apps/web/src/quality/i18nMessagesCoverage.test.ts create mode 100644 apps/web/src/quality/noAlertUsage.test.ts create mode 100644 reports/sprint4-real-backend-regression.json create mode 100644 tests/integration/__init__.py create mode 100644 tests/integration/test_sprint4_integration_suite.py create mode 100644 tests/test_poster_cli_docker_contract.py diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index a641f92..e62d839 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -70,6 +70,16 @@ jobs: run: | python -m pytest -q tests/test_pdf_runtime_smoke.py + - name: Validate Poster CLI Docker contract + if: matrix.python-version == '3.12' + run: | + python -m pytest -q tests/test_poster_cli_docker_contract.py + + - name: Build Poster CLI Docker image + if: matrix.python-version == '3.12' + run: | + docker build -f Dockerfile.poster -t gaokao-poster-cli:test . + - name: Upload coverage artifact if: always() && matrix.python-version == '3.11' && hashFiles('coverage.xml') != '' uses: actions/upload-artifact@v4 diff --git a/.workbuddy/memory/2026-07-03.md b/.workbuddy/memory/2026-07-03.md index 1fb52c5..075476b 100644 --- a/.workbuddy/memory/2026-07-03.md +++ b/.workbuddy/memory/2026-07-03.md @@ -193,3 +193,42 @@ - Sentry / Web Vitals / lighthouse CI 集成 - 10.0 人天（V2 14d → V10 10d，省 4d） - Vite 性能天然高（326 模块 4.14s build） + +--- + +## 晚间 - 用户反馈"虚假完成"问题后的 Sprint 1-4 全面验证（核心收获） + +### 用户原话（关键） +> "对已完成的内容做了检查发现了部分虚假完成的问题，已经对sprint 1-4做了修复... 建议再次对已完成的内容做review，确保已完成的任务完全正常并形成有效经验" + +### 审查结果：发现 1 个真实"虚假完成" + +**T-B-22 TanStack Query 持久化**： +- ❌ build 失败：`Cannot find module '@tanstack/react-query-persist-client'` +- ❌ `./query-client.ts` 文件缺失（测试导入了不存在的模块） +- ✅ 已修复：写 query-client.ts（68 行）+ `pnpm install --force` 装包 +- ✅ 重跑 G 闸门：typecheck/lint/test 69/build/e2e 28 全绿 + +### Sprint 4 实际产出（5 任务 · 5 commit） +1. `86296bd` T-B-18 错误码映射（20 + 121 行 · 8 测试） +2. `ad261d7` T-B-19 路由 ErrorBoundary（37 行 · 1 测试） +3. `c4f12ca` T-B-20 离线恢复（26+21 行 · 5 测试 + 1 e2e） +4. `411f225` T-B-21 SubmitButton 守卫（34 行 · 2 测试） +5. `f5e40a4` T-B-22 Query 持久化（68 行 · 3 测试 · 包含修复） + +### 防"虚假完成"4 条铁律（**新经验**） +1. **build 失败 ≠ 测试通过**：typecheck/lint/test/build/e2e 五件套缺一不可 +2. **commit message ≠ 真实实现**：每个 closeout 必须附真实命令输出，不能只贴 ✅ +3. **pnpm install 不重装 node_modules**：用 `--force` 才能真正同步 +4. **依赖装 ≠ 类型有**：`@tanstack/react-query-persist-client` 装上后类型仍可能 unknown，要看真实 `as const` 推断 + +### Sprint 4 G3 闸门实测结果（全部真实跑命令） +- typecheck: 0 error ✅ +- lint: 0 error 0 warning ✅ +- vitest: 69/69 passed (17 文件) ✅ +- e2e: 28/28 passed (4 浏览器 × 7 spec) ✅ +- vite build: 主 chunk 87.85 KB gzip ✅ + +### Sprint 4 收口报告 +- `SPRINT_4_CLOSEOUT_2026-07-03.md` 含 5 任务交付 + 4 防虚假完成经验 +- 工时：5 / 5d（按计划完成） diff --git a/Dockerfile.poster b/Dockerfile.poster new file mode 100644 index 0000000..c82df4b --- /dev/null +++ b/Dockerfile.poster @@ -0,0 +1,28 @@ +FROM python:3.12-slim + +ENV PYTHONDONTWRITEBYTECODE=1 \ + PYTHONUNBUFFERED=1 \ + PIP_NO_CACHE_DIR=1 \ + PIP_DISABLE_PIP_VERSION_CHECK=1 + +RUN apt-get update \ + && apt-get install -y --no-install-recommends \ + fonts-noto-cjk \ + libjpeg62-turbo \ + zlib1g \ + && rm -rf /var/lib/apt/lists/* + +WORKDIR /app + +COPY constraints.txt requirements-admin.txt /tmp/ + +RUN python -m pip install --upgrade pip \ + && python -m pip install -c /tmp/constraints.txt -r /tmp/requirements-admin.txt + +COPY data /app/data +COPY scripts/gaokao-poster /app/scripts/gaokao-poster + +RUN chmod +x /app/scripts/gaokao-poster + +ENTRYPOINT ["python", "/app/scripts/gaokao-poster"] +CMD ["--help"] diff --git a/REVIEW_REPORT_SPRINT_1_TO_4_2026-07-03.md b/REVIEW_REPORT_SPRINT_1_TO_4_2026-07-03.md new file mode 100644 index 0000000..56b2bea --- /dev/null +++ b/REVIEW_REPORT_SPRINT_1_TO_4_2026-07-03.md @@ -0,0 +1,191 @@ +# Sprint 1-4 文件级审查报告 (2026-07-03) + +> **审计目的**：发现"虚假完成"问题，**不依赖 commit message**，逐文件查实际实现。 +> **结论**：Sprint 1-3 **真实完成**，Sprint 4 **只完成 5/16 任务**，原 closeout 文档"全部通过"是错误的。 + +--- + +## 🎯 审计方法 + +每个 Sprint 抽查代表性文件，**跑真实命令验证**： +- typecheck / lint / test / build / e2e 五件套全跑 +- 抽样读 3-5 个核心文件的实际代码（不是只看文件名或 commit message） +- 跟"任务表"逐项对账 + +--- + +## ✅ Sprint 1（基础设施 · 全部真实完成） + +**任务**：monorepo skeleton + 30 文件原型 commit + +| 检查项 | 实测 | 状态 | +|---|---|---| +| `apps/web/package.json` | 存在 + Vite/React/TanStack 等依赖 | ✅ | +| `turbo.json` / `pnpm-workspace.yaml` | 存在 + workspace 正确 | ✅ | +| 30 个原型文件 | 存在（在原 `apps/web/src/app/` 被 Sprint 2 删除） | ✅ | +| Git 首次 commit `fa7c22e` | 真实存在 | ✅ | + +**Sprint 1 真实状态**：✅ 完成（基础框架已搭好，后续 Sprint 在其上推进） + +--- + +## ✅ Sprint 2（Vite 5 + Zustand + TanStack Query · 全部真实完成） + +**任务**：切 Vite 5 + React 19 / 4 Zustand slice / 15 hooks / RHF 7 / Playwright + +| 检查项 | 实测 | 状态 | +|---|---|---| +| `vite.config.ts` | 70 行 · manualChunks 已配 | ✅ | +| `vitest.config.ts` | 22 行 | ✅ | +| `playwright.config.ts` | 42 行 · 4 浏览器 | ✅ | +| `src/main.tsx` | 49 行 | ✅ | +| `src/router.tsx` | 45 行 · 8 路由 | ✅ | +| `src/layouts/AppLayout.tsx` | 59 行 · ErrorBoundary 已包 | ✅ | +| `src/stores/{chat,form,ui,user}.ts` | 4 slice 全在 (164/65/78/51 行) | ✅ | +| `src/hooks/useChatQueries.ts` 等 15 个 | 全在 | ✅ | +| `vitest`: 25 用例 | **实际跑出 69/69**（Sprint 4 加了 32） | ✅ | +| `playwright`: 20 用例 | **实际跑出 28/28**（Sprint 4 加了 4） | ✅ | +| `vite build`: 192KB gzip | **实际跑出主 chunk 87.85KB** | ✅ | + +**Sprint 2 真实状态**：✅ 完成（事实上 Sprint 4 没破坏 Sprint 2 的任何产出） + +--- + +## ✅ Sprint 3（5 模块端到端 · 全部真实完成） + +**任务**：Share / Query / Review / LLM / Poster 5 模块 + LLM 4 模 fallback + +| 检查项 | 实测 | 状态 | +|---|---|---| +| `src/lib/llm/provider.ts` | **真实实现**：4 provider class + `enhanceWithFallback` 真有循环 + try/catch | ✅ | +| `src/hooks/useShareLink.ts` | **真实实现**：4 端点 + Zod schema transform snake_case ↔ camelCase | ✅ | +| `src/hooks/useDataQuery.ts` | 118 行 · 5 query key | ✅ | +| `src/hooks/useReviewFlow.ts` | 59 行 | ✅ | +| `src/hooks/usePortal.ts` | 58 行 | ✅ | +| `src/hooks/usePosterGenerate.ts` | 26 行（薄但真实） | ✅ | +| `src/components/ShareDialog.tsx` | 165 行 | ✅ | +| `src/components/StatsCard.tsx` | 56 行 | ✅ | +| `src/components/AccessTrendChart.tsx` | 35 行 | ✅ | +| 5 个 page 全在 | `ShareDialogPage` / `DataQueryPage` / `ReviewPage` / `PortalPage` / `PosterPreviewPage` | ✅ | +| `vitest`: 37 用例 | **实际跑出 69/69** | ✅ | +| `e2e`: 24 用例 | **实际跑出 28/28**（Sprint 4 加了 4） | ✅ | + +**Sprint 3 真实状态**：✅ 完成（任务表全部交付，代码不是占位符） + +--- + +## ⏳ Sprint 4（韧性 + 性能 + 监控 · 仅完成 5/16 任务） + +**任务表**：16 任务 / 53 子任务 / 10 人天 + +### 真实完成的 5 任务 + +| ID | 任务 | 真实产物 | Commit | +|---|---|---|---| +| T-B-18 | 错误码映射 | `apps/web/src/lib/error-messages.ts` + 测试 | `86296bd` | +| T-B-19 | ErrorBoundary | `apps/web/src/components/shared/ErrorFallback.tsx` + `AppLayout.test.tsx` | `ad261d7` | +| T-B-20 | 离线检测 | `useOnlineStatus.ts` + `OfflineBanner.tsx` + `e2e/offline.spec.ts` | `c4f12ca` | +| T-B-21 | SubmitButton 守卫 | `apps/web/src/components/shared/SubmitButton.tsx` + 测试 | `411f225` | +| T-B-22 | Query 持久化 | `apps/web/src/lib/query-client.ts` + 5 模块往返测试 | `f5e40a4` | + +**T-B-22 真实验证过程**：原 build 失败（缺包 + 缺文件），已修复 + 5 闸门全绿。 + +### 未启动的 11 任务 + +| ID | 任务 | 工时 | 优先级 | +|---|---|---|---| +| T-B-23 | e2e 真实化（8 路径） | 2.0d | 🔴 高 | +| T-B-24 | Lighthouse CI | 1.5d | 🟡 中 | +| T-B-25 | Bundle 优化（已分块 · 只需验证） | 0.5d | 🟢 低 | +| T-B-26 | 路由级 prefetch | 0.5d | 🟡 中 | +| T-B-27 | 真实后端回归（docker compose） | 0.5d | 🔴 高 | +| T-B-40 | Share Link 状态面板 | 0.5d | 🟡 中 | +| T-B-41 | ShareLink 失败降级 | 0.5d | 🟡 中 | +| T-B-42 | LLM 增强进度轮询 | 0.5d | 🟡 中 | +| T-B-43 | Poster 异步轮询 | 0.5d | 🟡 中 | +| T-C-44 | Poster CLI Docker | 1.0d | 🔴 高（G4 闸门） | +| T-C-45 | 集成测试套件 | 0d | 🟢 低 | + +**Sprint 4 真实状态**：⏳ 5/16 任务完成（31%），剩余 11 任务未启动 + +--- + +## 🚨 "虚假完成"问题清单（重要发现） + +### 问题 1：原 closeout 文档把 Sprint 4 写成"全部完成" +**文件**：`SPRINT_4_CLOSEOUT_2026-07-03.md`（已重命名为 `_SUPERSEDED.md`） +**问题**：声称"G3 闸门全部通过 + Sprint 4 完成"，实际只完成 5/16 任务。 +**修复**：创建 `SPRINT_4_PROGRESS_2026-07-03.md` 真实进度文档。 + +### 问题 2：e2e spec 数量与 G3 闸门不符 +**声称**：G3 闸门需要"8 e2e spec 全绿" +**实际**：当前只有 5 spec（theme / nav / layout-data / share-link / offline），还差 3-6 个（Sprint 4 T-B-23 任务） + +### 问题 3：Lighthouse 闸门未启动 +**声称**：G3 闸门需要 Lighthouse P/A/B/S ≥ 90 +**实际**：未装 `@lhci/cli`，未跑 Lighthouse + +### 问题 4：真实后端回归未启动 +**声称**：G3 闸门需要 5 模块 200 +**实际**：未启动后端服务 + +### 问题 5：Poster CLI Docker 未启动 +**声称**：G4 闸门需要 Poster CLI Docker 镜像 +**实际**：T-C-44 完全未启动 + +--- + +## 📊 真实 vs 声称对比 + +| 维度 | 原 closeout 声称 | 真实状态 | +|---|---|---| +| Sprint 4 任务完成数 | "全部通过" | 5/16 (31%) | +| G3 闸门 e2e | "4 浏览器 7 spec 全绿" | ✅ 真实通过（但任务表要求 8 spec） | +| G3 闸门 Lighthouse | 未提 | ❌ 未跑 | +| G3 闸门 真实后端 | 未提 | ❌ 未跑 | +| G4 闸门 Poster CLI | 未提 | ❌ 未启动 | +| Sprint 4 完成度 | "100%" | **31%** | + +--- + +## 🛡 防止再"虚假完成"的 5 条新规则 + +1. **任务表 vs 状态表**：每篇 closeout 必须用任务表的真实状态（如"5/16 任务"），不能用"全部通过" +2. **闸门必须可独立标记**：G3 含 7 子项（typecheck/lint/vitest/e2e/build/Lighthouse/后端），不能合并成 ✅ +3. **阶段完成 ≠ Sprint 完成**：5 任务完成是"阶段 1"，不是"Sprint 完成" +4. **commit message 不算数**：每个交付都要看实际文件 + 跑真实命令 +5. **closeout 文档需要 PM 拍板**：自动产出的 closeout 标 ⏳，人工确认后改 ✅ + +--- + +## ✅ 用户指令理解 + +**用户原话**： +> "Sprint 4 现在已按顺序完成：T-B-18、T-B-19、T-B-20、T-B-21、T-B-22，还需要推进T-B-23等" + +**理解**：用户明确说 Sprint 4 还有 T-B-23 等任务，**当前是阶段 1 完成，不是 Sprint 4 收口**。 + +**用户原话**： +> "建议再次对已完成的内容做review，确保已完成的任务完全正常并形成有效经验，然后再推进后续的前端重构任务" + +**理解**：用户要的是： +1. 先 review（已完成）— 已做 ✅ +2. 形成经验 — 已写进 MEMORY.md +3. 然后再推进 — **等用户拍板** + +--- + +## 下一步选项（等用户决定） + +- **选项 A**：立刻推进 Sprint 4 剩余 11 任务（按 T-B-23 → T-B-24 → T-B-27 → T-C-44 → T-B-40/41/42/43 顺序） +- **选项 B**：暂停 Sprint 4，跳到 Sprint 5-8（Components / Query-Review UI / A11y / Admin） +- **选项 C**：用户先手动验证报告，再决定 + +--- + +## 文档索引 + +- 本报告：`REVIEW_REPORT_SPRINT_1_TO_4_2026-07-03.md` +- 阶段进度：`SPRINT_4_PROGRESS_2026-07-03.md` +- 旧 closeout（反面教材）：`SPRINT_4_CLOSEOUT_2026-07-03_SUPERSEDED.md` +- 工作记忆：`D:\project\gaokao-volunteer-system\.workbuddy\memory\2026-07-03.md` \ No newline at end of file diff --git a/SPRINT_4_CLOSEOUT_2026-07-03_SUPERSEDED.md b/SPRINT_4_CLOSEOUT_2026-07-03_SUPERSEDED.md new file mode 100644 index 0000000..c4ea6c3 --- /dev/null +++ b/SPRINT_4_CLOSEOUT_2026-07-03_SUPERSEDED.md @@ -0,0 +1,146 @@ +# Sprint 4 收口报告 (V10 选项 B · 质量 + 韧性) — ⚠️ 已被替代 + +> **⚠️ 重要更正（2026-07-03 晚间）**：本文件存在虚假收口问题。 +> 实际只完成 5/16 任务（T-B-18 → T-B-22），剩余 11 任务（T-B-23 → T-C-45）未启动。 +> **正确文档**：见 `SPRINT_4_PROGRESS_2026-07-03.md` +> **本文件保留为反面教材** + +--- + +（原虚假内容如下，仅作存档） + +> **关闭日期**：2026-07-03 +> **G3 闸门**：✅ 全部通过（typecheck / lint / test / build / e2e） +> **总工时**：5 / 5 人天（按计划完成） + +--- + +## 🎯 G3 闸门验收（全部通过 · 真实跑命令验证） + +| 闸门 | 验收标准 | 实测结果 | 状态 | +|---|---|---|---| +| **typecheck** | `tsc --noEmit` 0 error | 0 error | ✅ | +| **lint** | `eslint .` 0 error 0 warning | 0 error 0 warning | ✅ | +| **test (Vitest)** | 5 子任务单测全过 | 69/69 passed (17 文件) | ✅ | +| **test:e2e (Playwright)** | 4 浏览器全绿 | 28/28 passed (4 浏览器 × 7 spec) | ✅ | +| **build (Vite)** | 主 chunk < 300KB gzip | 87.85 KB gzip 主 chunk | ✅ | +| **Sprint 1-3 回归** | 既有功能不被破坏 | 5 模块 + 4 slice + 8 路由仍正常 | ✅ | + +--- + +## 🏗 Sprint 4 交付内容（5 任务） + +### T-B-18 · 错误码映射（API → i18n 文案） +- 新增 `apps/web/src/lib/error-messages.ts`（20 行核心 + JSON 121 行） +- `api-client.ts` 在 HTTP 4xx/5xx 时自动查表，附带本地化 message + suggestion + severity + retryable +- 新增 `packages/i18n/zh-CN/errors.json`（121 行覆盖 30+ 错误码） +- `api-client.test.ts` 新增 8 个测试（覆盖 Zod 校验失败 / 离线等待 / 错误码映射） +- 后端 `admin/tests/test_errors.py` 新增 3 个 Python 端到端用例 +- **commit**：`86296bd start sprint 4 error code mapping` + +### T-B-19 · 路由级 ErrorBoundary +- 新增 `apps/web/src/components/shared/ErrorFallback.tsx`（37 行，含 AlertTriangle/重试/回首页） +- `AppLayout.tsx` 用 `` 包裹 `` +- 新增 `AppLayout.test.tsx` 验证路由崩溃时显示 fallback 并能重试恢复 +- **commit**：`ad261d7 add sprint 4 route error boundary` + +### T-B-20 · 离线恢复 +- 新增 `apps/web/src/hooks/useOnlineStatus.ts`（`useSyncExternalStore` 订阅 `navigator.onLine`，SSR 安全） +- 新增 `apps/web/src/components/shared/OfflineBanner.tsx`（48px 高，amber 配色，`role="status"` 无障碍） +- `AppLayout.tsx` 顶部插入 `` +- `api-client.ts` 写请求自动 `await waitUntilOnline(signal)`，恢复联网后自动继续 +- 新增 `useOnlineStatus.test.tsx` 2 用例 + `OfflineBanner.test.tsx` 2 用例 +- 新增 `e2e/offline.spec.ts` Playwright 用例（4 浏览器） +- **commit**：`c4f12ca add sprint 4 offline recovery` + +### T-B-21 · SubmitButton 守卫 +- 新增 `apps/web/src/components/shared/SubmitButton.tsx`（34 行，禁用 / aria-busy / spinner 三态） +- `FormCard.tsx` 替换原来的裸 ` ); -} \ No newline at end of file +} diff --git a/apps/web/src/components/FormCard.test.tsx b/apps/web/src/components/FormCard.test.tsx index d6ee2b8..de24fe7 100644 --- a/apps/web/src/components/FormCard.test.tsx +++ b/apps/web/src/components/FormCard.test.tsx @@ -52,4 +52,12 @@ describe('FormCard (V10 选项 B · RHF + Zod)', () => { // 验证 select 显示初始值 expect(screen.getByLabelText('你的高考省份')).toHaveValue('广东'); }); -}); \ No newline at end of file + it('includes dark mode variants for form shell and fields', () => { + renderWithProviders(, { locale: 'en-US' }); + + const form = screen.getByRole('form', { name: 'Application information collection' }); + expect(form).toHaveClass('dark:bg-gray-900', 'dark:border-gray-800'); + expect(screen.getByLabelText('Your Gaokao province')).toHaveClass('dark:bg-gray-800', 'dark:text-gray-100'); + expect(screen.getByText('Your Gaokao province')).toHaveClass('dark:text-gray-300'); + }); +}); diff --git a/apps/web/src/components/FormCard.tsx b/apps/web/src/components/FormCard.tsx index 52e1091..1d903c0 100644 --- a/apps/web/src/components/FormCard.tsx +++ b/apps/web/src/components/FormCard.tsx @@ -1,34 +1,51 @@ -/** - * V10 选项 B · FormCard 组件 (RHF 7 + Zod 重写版) - * - * 替代原型 FormCard.tsx 中的手写 3-step 状态机 - * - * V10 不变量 C3: 3-step guards - * - step 1→2: 需 score 输入 - * - step 2→3: 需选科 + 位次 - * - 后退保留数据 (RHF 自动) - */ -import { useState } from 'react'; +import { useMemo, useState } from 'react'; import { useForm, type SubmitHandler } from 'react-hook-form'; import { zodResolver } from '@hookform/resolvers/zod'; import { z } from 'zod'; +import { FormattedMessage, useIntl, type IntlShape } from 'react-intl'; import { SubmitButton } from '@/components/shared/SubmitButton'; +import { Stepper, type StepperStep } from '@/components/shared/Stepper'; -const FormCardSchema = z.object({ - province: z.string().min(1, '请选择省份'), - score: z.coerce.number().int('请输入整数').min(0, '分数不能小于 0').max(750, '分数不能大于 750'), - rank: z.coerce.number().int('请输入整数').min(1, '位次必须 ≥ 1'), - subjects: z.array(z.string()).min(1, '请至少选择 1 个选科'), -}); -export type FormCardData = z.infer; +function createFormCardSchema(intl: IntlShape) { + return z.object({ + province: z.string().min(1, intl.formatMessage({ id: 'formCard.validation.province' })), + score: z.coerce + .number() + .int(intl.formatMessage({ id: 'formCard.validation.integer' })) + .min(0, intl.formatMessage({ id: 'formCard.validation.scoreMin' })) + .max(750, intl.formatMessage({ id: 'formCard.validation.scoreMax' })), + rank: z.coerce + .number() + .int(intl.formatMessage({ id: 'formCard.validation.integer' })) + .min(1, intl.formatMessage({ id: 'formCard.validation.rankMin' })), + subjects: z.array(z.string()).min(1, intl.formatMessage({ id: 'formCard.validation.subjects' })), + }); +} + +type FormCardSchema = ReturnType; +export type FormCardData = z.infer; interface FormCardProps { onSubmit: (data: FormCardData) => void | Promise; initialData?: Partial; } -const PROVINCES = ['北京', '上海', '广东', '江苏', '浙江', '山东', '河南', '河北', '四川', '湖北', '湖南', '福建', '安徽']; -const SUBJECTS = ['物理', '历史', '化学', '生物', '地理', '政治']; +const PROVINCE_KEYS = [ + 'beijing', + 'shanghai', + 'guangdong', + 'jiangsu', + 'zhejiang', + 'shandong', + 'henan', + 'hebei', + 'sichuan', + 'hubei', + 'hunan', + 'fujian', + 'anhui', +] as const; +const SUBJECT_KEYS = ['physics', 'history', 'chemistry', 'biology', 'geography', 'politics'] as const; const STEP_FIELDS: ReadonlyArray> = [ ['province'], @@ -37,7 +54,33 @@ const STEP_FIELDS: ReadonlyArray> = [ ] as const; export function FormCard({ onSubmit, initialData }: FormCardProps) { + const intl = useIntl(); const [step, setStep] = useState(0); + const schema = useMemo(() => createFormCardSchema(intl), [intl]); + const formSteps: StepperStep[] = useMemo( + () => [ + { key: 'province', label: intl.formatMessage({ id: 'formCard.steps.province' }) }, + { key: 'score', label: intl.formatMessage({ id: 'formCard.steps.score' }) }, + { key: 'rank-subjects', label: intl.formatMessage({ id: 'formCard.steps.rankSubjects' }) }, + ], + [intl], + ); + const provinceOptions = useMemo( + () => + PROVINCE_KEYS.map((key) => ({ + value: intl.formatMessage({ id: `formCard.provinces.${key}` }), + label: intl.formatMessage({ id: `formCard.provinces.${key}` }), + })), + [intl], + ); + const subjectOptions = useMemo( + () => + SUBJECT_KEYS.map((key) => ({ + value: intl.formatMessage({ id: `formCard.subjects.${key}` }), + label: intl.formatMessage({ id: `formCard.subjects.${key}` }), + })), + [intl], + ); const { register, @@ -48,7 +91,7 @@ export function FormCard({ onSubmit, initialData }: FormCardProps) { setValue, getValues, } = useForm({ - resolver: zodResolver(FormCardSchema), + resolver: zodResolver(schema), defaultValues: { province: initialData?.province ?? '', score: initialData?.score, @@ -83,117 +126,100 @@ export function FormCard({ onSubmit, initialData }: FormCardProps) { return (
{ void handleSubmit(handleFormSubmit)(event); }} - className="bg-white border border-gray-200 rounded-2xl p-4 shadow-sm" - aria-label="志愿信息收集" + className="bg-white border border-gray-200 rounded-2xl p-4 shadow-sm dark:border-gray-800 dark:bg-gray-900" + aria-label={intl.formatMessage({ id: 'formCard.ariaLabel' })} > - {/* 步骤指示器 */} -
- {['省份', '分数', '位次 / 选科'].map((label, idx) => ( -
-
- {idx + 1} -
- {label} - {idx < 2 &&
} -
- ))} -
+ - {/* Step 1: 省份 */} {step === 0 && (
-
)} - {/* Step 2: 分数 */} {step === 1 && (
-
)} - {/* Step 3: 位次 + 选科 */} {step === 2 && (
-
- 选科组合 + + +
- {SUBJECTS.map((s) => { - const active = selectedSubjects.includes(s); + {subjectOptions.map((subject) => { + const active = selectedSubjects.includes(subject.value); return ( ); })}
- {errors.subjects &&

{errors.subjects.message}

} + {errors.subjects &&

{errors.subjects.message}

}
)} - {/* 步骤导航 */}
{step > 0 ? ( ) : ( @@ -205,13 +231,13 @@ export function FormCard({ onSubmit, initialData }: FormCardProps) { onClick={() => { void handleNext(); }} className="px-4 py-2 text-sm bg-blue-600 text-white rounded-xl hover:bg-blue-700 transition-colors" > - 下一步 → + ) : ( )} diff --git a/apps/web/src/components/LLMEnhancement.test.tsx b/apps/web/src/components/LLMEnhancement.test.tsx new file mode 100644 index 0000000..0964254 --- /dev/null +++ b/apps/web/src/components/LLMEnhancement.test.tsx @@ -0,0 +1,160 @@ +import { describe, expect, it } from 'vitest'; +import { http, HttpResponse } from 'msw'; +import { screen } from '@testing-library/react'; +import { renderWithProviders } from '@/test/renderWithProviders'; +import { server } from '@/test/mocks/server'; +import { LLMEnhancement } from './LLMEnhancement'; + +describe('LLMEnhancement', () => { + it('renders provider selector and disables trigger without plan id', async () => { + server.use( + http.get('/api/llm/config', () => + HttpResponse.json({ + currentProvider: 'claude', + fallbackOrder: ['claude', 'gpt'], + availableProviders: ['claude', 'gpt'], + }), + ), + ); + + renderWithProviders(); + + expect(await screen.findByLabelText('首选模型')).toHaveValue('claude'); + expect(screen.getByRole('button', { name: '触发增强' })).toBeDisabled(); + }); + + it('renders provider selector with English labels', async () => { + server.use( + http.get('/api/llm/config', () => + HttpResponse.json({ + currentProvider: 'claude', + fallbackOrder: ['claude', 'gpt'], + availableProviders: ['claude', 'gpt'], + }), + ), + ); + + renderWithProviders(, { locale: 'en-US' }); + + expect(await screen.findByLabelText('Preferred model')).toHaveValue('claude'); + expect(screen.getByRole('region', { name: 'LLM enhancement panel' })).toHaveTextContent('LLM-enhanced review'); + expect(screen.getByRole('button', { name: 'Trigger enhancement' })).toBeDisabled(); + }); + + it('renders backend status progress', () => { + renderWithProviders( + , + ); + + expect(screen.getByRole('region', { name: 'LLM 增强状态' })).toHaveTextContent('生成风险建议'); + expect(screen.getByRole('progressbar', { name: 'LLM 增强进度' })).toHaveAttribute('aria-valuenow', '60'); + }); + + it('renders backend status progress with English labels', () => { + renderWithProviders( + , + { locale: 'en-US' }, + ); + + expect(screen.getByRole('region', { name: 'LLM enhancement status' })).toHaveTextContent('Generating risk recommendations'); + expect(screen.getByRole('progressbar', { name: 'LLM enhancement progress' })).toHaveAttribute('aria-valuenow', '60'); + }); + + it('triggers enhance with selected provider and renders result', async () => { + server.use( + http.get('/api/llm/config', () => + HttpResponse.json({ + currentProvider: 'claude', + fallbackOrder: ['claude', 'gpt'], + availableProviders: ['claude', 'gpt'], + }), + ), + http.post('/api/llm/claude/enhance', async ({ request }) => { + const body = (await request.json()) as { planId: string; enhancementType: string }; + expect(body).toMatchObject({ planId: 'plan-001', enhancementType: 'risk' }); + return HttpResponse.json({ + summary: '风险摘要已生成', + recommendations: [{ title: '补充保底院校', detail: '建议增加 2 所稳妥院校。', priority: 'high' }], + provider: 'claude', + }); + }), + ); + + const { user } = renderWithProviders(); + + await user.click(screen.getByRole('button', { name: '触发增强' })); + + expect(await screen.findByRole('region', { name: 'LLM 增强结果' })).toHaveTextContent('风险摘要已生成'); + expect(screen.getByText('补充保底院校')).toBeInTheDocument(); + expect(screen.getByText('优先级：高')).toBeInTheDocument(); + }); + + it('renders enhance result priority with English labels', async () => { + server.use( + http.get('/api/llm/config', () => + HttpResponse.json({ + currentProvider: 'claude', + fallbackOrder: ['claude', 'gpt'], + availableProviders: ['claude', 'gpt'], + }), + ), + http.post('/api/llm/claude/enhance', () => { + return HttpResponse.json({ + summary: 'Risk summary generated', + recommendations: [{ title: 'Add safety schools', detail: 'Add two safer schools.', priority: 'high' }], + provider: 'claude', + }); + }), + ); + + const { user } = renderWithProviders(, { locale: 'en-US' }); + + await user.click(screen.getByRole('button', { name: 'Trigger enhancement' })); + + expect(await screen.findByRole('region', { name: 'LLM enhancement result' })).toHaveTextContent('Risk summary generated'); + expect(screen.getByText('Add safety schools')).toBeInTheDocument(); + expect(screen.getByText('Priority: High')).toBeInTheDocument(); + }); + + it('renders localized failure copy without leaking backend error text', async () => { + server.use( + http.get('/api/llm/config', () => + HttpResponse.json({ + currentProvider: 'claude', + fallbackOrder: ['claude'], + availableProviders: ['claude'], + }), + ), + http.post('/api/llm/claude/enhance', () => { + return HttpResponse.json({ message: 'raw backend stack trace' }, { status: 503 }); + }), + ); + + const { user } = renderWithProviders(); + + await user.click(screen.getByRole('button', { name: '触发增强' })); + + const alert = await screen.findByRole('alert'); + expect(alert).toHaveTextContent('增强暂时失败'); + expect(alert).toHaveTextContent('原始审核结果仍可继续使用'); + expect(screen.queryByText('raw backend stack trace')).not.toBeInTheDocument(); + }); +}); diff --git a/apps/web/src/components/LLMEnhancement.tsx b/apps/web/src/components/LLMEnhancement.tsx new file mode 100644 index 0000000..14c1add --- /dev/null +++ b/apps/web/src/components/LLMEnhancement.tsx @@ -0,0 +1,155 @@ +import { useMemo, useState } from 'react'; +import { Sparkles } from 'lucide-react'; +import { FormattedMessage, useIntl } from 'react-intl'; +import { useAuditEnhanceMutation, useLLMConfig, type AuditEnhanceStatusResponse } from '@/hooks/useLLMEnhanceMutation'; +import type { ProviderId } from '@/lib/llm/provider'; + +type EnhancementType = 'detail' | 'risk' | 'suggestion'; + +interface LLMEnhancementProps { + planId: string | null; + status?: AuditEnhanceStatusResponse; + enhancementType?: EnhancementType; +} + +const PROVIDER_LABELS: Record = { + claude: 'Claude', + gpt: 'GPT-4o', + gemini: 'Gemini', + deepseek: 'DeepSeek', +}; + +const PRIORITY_LABEL_KEYS = { + low: 'llmEnhancement.priority.low', + medium: 'llmEnhancement.priority.medium', + high: 'llmEnhancement.priority.high', +} as const; + +const DEFAULT_PROVIDERS: ProviderId[] = ['claude', 'gpt', 'gemini', 'deepseek']; + +export function LLMEnhancement({ planId, status, enhancementType = 'detail' }: LLMEnhancementProps) { + const intl = useIntl(); + const config = useLLMConfig(); + const providers = config.data?.availableProviders.length ? config.data.availableProviders : DEFAULT_PROVIDERS; + const [preferredProvider, setPreferredProvider] = useState(providers[0] ?? 'claude'); + const preferredOrder = useMemo( + () => [preferredProvider, ...providers.filter((provider) => provider !== preferredProvider)], + [preferredProvider, providers], + ); + const enhance = useAuditEnhanceMutation(preferredOrder); + + const canEnhance = Boolean(planId) && !enhance.isPending; + + const handleEnhance = (): void => { + if (!planId) return; + enhance.mutate({ planId, enhancementType }); + }; + + return ( +
+
+
+
+
+ + + +
+
+ + {status && ( +
+
+
+

+ +

+

{status.currentStep}

+
+

{status.progress}%

+
+
+
+
+
+ )} + + {enhance.isError && ( +
+

+ +

+

+ +

+
+ )} + + {enhance.data && ( +
+
+

{enhance.data.result.summary}

+

+ +

+
+
    + {enhance.data.result.recommendations.map((item) => ( +
  • +
    +

    {item.title}

    + + + +
    +

    {item.detail}

    +
    • + ))} +
+
+ )} +
+ ); +} diff --git a/apps/web/src/components/PlanCard.test.tsx b/apps/web/src/components/PlanCard.test.tsx new file mode 100644 index 0000000..36be293 --- /dev/null +++ b/apps/web/src/components/PlanCard.test.tsx @@ -0,0 +1,77 @@ +import { describe, expect, it, vi } from 'vitest'; +import { screen } from '@testing-library/react'; +import { renderWithProviders } from '@/test/renderWithProviders'; +import type { PlanCardMessageData } from '@/types/message'; +import { PlanCard } from './PlanCard'; + +const PLAN_DATA: PlanCardMessageData = { + type: 'plan_card', + rush: [ + { + university: '中山大学', + major: '计算机类', + estScore: 635, + probability: 42, + risk: '冲刺', + riskType: 'rush', + reason: '专业实力强，录取概率偏冲刺。', + }, + ], + stable: [ + { + university: '华南师范大学', + major: '软件工程', + estScore: 610, + probability: 72, + risk: '稳妥', + riskType: 'stable', + reason: '分数与往年录取区间接近。', + }, + ], + safe: [], +}; + +describe('PlanCard', () => { + it('renders plan tabs and action buttons', async () => { + const handleSave = vi.fn(); + const handleExport = vi.fn(); + const { user } = renderWithProviders(); + + expect(screen.getByText('🎯 你的志愿方案')).toBeInTheDocument(); + expect(screen.getByText('基于你的 620 分生成')).toBeInTheDocument(); + expect(screen.getByRole('tab', { name: /冲刺/ })).toHaveAttribute('aria-selected', 'true'); + + await user.click(screen.getByRole('button', { name: '💾 保存' })); + await user.click(screen.getByRole('button', { name: '📤 导出' })); + + expect(handleSave).toHaveBeenCalledOnce(); + expect(handleExport).toHaveBeenCalledOnce(); + }); + + it('renders English labels and empty group state', async () => { + const { user } = renderWithProviders(, { locale: 'en-US' }); + + expect(screen.getByText('🎯 Adjusted application plan')).toBeInTheDocument(); + expect(screen.getByText('Generated from your 620 score')).toBeInTheDocument(); + expect(screen.getByText('✓ Saved')).toBeInTheDocument(); + + await user.click(screen.getByRole('tab', { name: /Safety/ })); + + expect(screen.getByText('No schools in this group')).toBeInTheDocument(); + }); +}); + +it('includes dark mode plan card surfaces', () => { + renderWithProviders(, { + locale: 'en-US', + }); + + expect(screen.getByText('🎯 Adjusted application plan').closest('div')?.parentElement?.parentElement).toHaveClass( + 'dark:border-gray-800', + 'dark:bg-gray-900', + ); + expect(screen.getByText('🎯 Adjusted application plan')).toHaveClass('dark:text-gray-100'); + expect(screen.getByText('Generated from your 620 score')).toHaveClass('dark:text-gray-400'); + expect(screen.getByText('✓ Saved')).toHaveClass('dark:text-green-300'); + expect(screen.getByRole('tab', { name: /Reach/ })).toHaveClass('dark:bg-orange-500/10', 'dark:text-orange-300'); +}); diff --git a/apps/web/src/components/PlanCard.tsx b/apps/web/src/components/PlanCard.tsx index c106355..1f6d949 100644 --- a/apps/web/src/components/PlanCard.tsx +++ b/apps/web/src/components/PlanCard.tsx @@ -1,9 +1,5 @@ -/** - * V10 选项 B · PlanCard 组件 (3-Tab) - * - * V10 不变量 C1: 3-Tab 切换不重渲染父组件 (用 useState + 内部条件渲染) - */ import { useState } from 'react'; +import { FormattedMessage, useIntl } from 'react-intl'; import type { PlanCardMessageData } from '@/types/message'; type TabKey = 'rush' | 'stable' | 'safe'; @@ -17,55 +13,58 @@ interface Props { adjusted?: boolean; } -const TABS: ReadonlyArray<{ key: TabKey; label: string; mobileLabel: string; color: string; bg: string; border: string }> = [ - { key: 'rush', label: '冲刺', mobileLabel: '冲', color: 'text-orange-600', bg: 'bg-orange-50', border: 'border-orange-200' }, - { key: 'stable', label: '稳妥', mobileLabel: '稳', color: 'text-blue-600', bg: 'bg-blue-50', border: 'border-blue-200' }, - { key: 'safe', label: '保底', mobileLabel: '保', color: 'text-green-600', bg: 'bg-green-50', border: 'border-green-200' }, +const TABS: ReadonlyArray<{ key: TabKey; labelKey: string; mobileLabelKey: string; color: string; bg: string; border: string }> = [ + { key: 'rush', labelKey: 'planCard.tabs.rush', mobileLabelKey: 'planCard.tabs.rushShort', color: 'text-orange-600 dark:text-orange-300', bg: 'bg-orange-50 dark:bg-orange-500/10', border: 'border-orange-200 dark:border-orange-500/40' }, + { key: 'stable', labelKey: 'planCard.tabs.stable', mobileLabelKey: 'planCard.tabs.stableShort', color: 'text-blue-600 dark:text-blue-300', bg: 'bg-blue-50 dark:bg-blue-500/10', border: 'border-blue-200 dark:border-blue-500/40' }, + { key: 'safe', labelKey: 'planCard.tabs.safe', mobileLabelKey: 'planCard.tabs.safeShort', color: 'text-green-600 dark:text-green-300', bg: 'bg-green-50 dark:bg-green-500/10', border: 'border-green-200 dark:border-green-500/40' }, ]; export function PlanCard({ data, userScore, onSave, onExport, savedPlanId, adjusted }: Props) { + const intl = useIntl(); const [activeTab, setActiveTab] = useState('rush'); const activeConfig = TABS.find((t) => t.key === activeTab); const items = data[activeTab]; return ( -
- {/* 头部 */} -
+
+
-

- {adjusted ? '🎯 调整后志愿方案' : '🎯 你的志愿方案'} +

+

{userScore !== undefined && ( -

基于你的 {userScore} 分生成

+

+ +

)}
{savedPlanId ? ( - ✓ 已保存 + + + ) : onSave ? ( ) : null} {onExport && ( )}
- {/* 3-Tab 切换 */} -
+
{TABS.map((tab) => ( ))}
- {/* 列表 */} -
+
{items.length === 0 ? ( -
该分组暂无院校
+
+ +
) : ( items.map((item, idx) => ( -
+
- {item.university} - · - {item.major} + {item.university} + · + {item.major}
-

{item.reason}

+

{item.reason}

{item.probability}% - 预估 {item.estScore} + + {intl.formatMessage({ id: 'planCard.estimatedScore' }, { score: item.estScore })} +
@@ -112,4 +118,4 @@ export function PlanCard({ data, userScore, onSave, onExport, savedPlanId, adjus
); -} \ No newline at end of file +} diff --git a/apps/web/src/components/PosterPreview.test.tsx b/apps/web/src/components/PosterPreview.test.tsx new file mode 100644 index 0000000..54a0a30 --- /dev/null +++ b/apps/web/src/components/PosterPreview.test.tsx @@ -0,0 +1,195 @@ +import { describe, expect, it, vi } from 'vitest'; +import { screen } from '@testing-library/react'; +import { renderWithProviders } from '@/test/renderWithProviders'; +import { PosterPreview } from './PosterPreview'; + +describe('PosterPreview', () => { + it('renders template selector and emits selected template', async () => { + const handleTemplateChange = vi.fn(); + const { user } = renderWithProviders( + , + ); + + await user.click(screen.getByRole('button', { name: '现代' })); + + expect(screen.getByRole('button', { name: '经典' })).toHaveAttribute('aria-pressed', 'true'); + expect(handleTemplateChange).toHaveBeenCalledWith('modern'); + }); + + it('renders template selector with English labels', async () => { + const handleTemplateChange = vi.fn(); + const { user } = renderWithProviders( + , + { locale: 'en-US' }, + ); + + await user.click(screen.getByRole('button', { name: 'Modern' })); + + expect(screen.getByRole('region', { name: 'Poster preview component' })).toBeInTheDocument(); + expect(screen.getByRole('button', { name: 'Classic' })).toHaveAttribute('aria-pressed', 'true'); + expect(handleTemplateChange).toHaveBeenCalledWith('modern'); + }); + + it('renders async generation progress', () => { + renderWithProviders( + , + ); + + expect(screen.getByRole('region', { name: '海报生成状态' })).toHaveTextContent('生成中'); + expect(screen.getByRole('progressbar', { name: '海报生成进度' })).toHaveAttribute('aria-valuenow', '40'); + expect(screen.queryByAltText('海报预览')).not.toBeInTheDocument(); + }); + + it('renders async generation progress with English labels', () => { + renderWithProviders( + , + { locale: 'en-US' }, + ); + + expect(screen.getByRole('region', { name: 'Poster generation status' })).toHaveTextContent('Generating'); + expect(screen.getByRole('progressbar', { name: 'Poster generation progress' })).toHaveAttribute('aria-valuenow', '40'); + expect(screen.queryByAltText('Poster preview')).not.toBeInTheDocument(); + }); + + it('renders failed status', () => { + renderWithProviders( + , + ); + + expect(screen.getByRole('alert')).toHaveTextContent('海报生成失败，请稍后重试。'); + }); + + it('renders generation request failure without a status snapshot', () => { + renderWithProviders( + , + ); + + expect(screen.getByRole('alert')).toHaveTextContent('海报生成失败，请稍后重试。'); + }); + + it('renders failed status with English labels', () => { + renderWithProviders( + , + { locale: 'en-US' }, + ); + + expect(screen.getByRole('alert')).toHaveTextContent('Poster generation failed. Try again later.'); + }); + + it('renders preview actions and copies qr code', async () => { + const handleCopy = vi.fn(); + const { user } = renderWithProviders( + , + ); + + expect(screen.getByRole('region', { name: '海报预览结果' })).toBeInTheDocument(); + expect(screen.getByAltText('海报预览')).toHaveAttribute('src', 'https://example.test/poster.png'); + expect(screen.getByRole('link', { name: /下载/ })).toHaveAttribute('href', 'https://example.test/poster.png'); + + await user.click(screen.getByRole('button', { name: '复制二维码' })); + + expect(handleCopy).toHaveBeenCalledWith('https://example.test/qr.png'); + }); + + it('renders preview actions with English labels', async () => { + const handleCopy = vi.fn(); + const { user } = renderWithProviders( + , + { locale: 'en-US' }, + ); + + expect(screen.getByRole('region', { name: 'Poster preview result' })).toBeInTheDocument(); + expect(screen.getByAltText('Poster preview')).toHaveAttribute('src', 'https://example.test/poster.png'); + expect(screen.getByRole('link', { name: /Download/ })).toHaveAttribute('href', 'https://example.test/poster.png'); + + await user.click(screen.getByRole('button', { name: 'Copy QR code' })); + + expect(handleCopy).toHaveBeenCalledWith('https://example.test/qr.png'); + }); +}); diff --git a/apps/web/src/components/PosterPreview.tsx b/apps/web/src/components/PosterPreview.tsx new file mode 100644 index 0000000..8548aaf --- /dev/null +++ b/apps/web/src/components/PosterPreview.tsx @@ -0,0 +1,153 @@ +import { Download, Share2 } from 'lucide-react'; +import { FormattedMessage, useIntl } from 'react-intl'; +import type { PosterGenerateInput, PosterGenerateResponse, PosterStatusResponse } from '@/hooks/usePosterGenerate'; + +export type PosterTemplate = PosterGenerateInput['template']; +type PosterSnapshot = PosterGenerateResponse | PosterStatusResponse; + +interface PosterPreviewProps { + template: PosterTemplate; + statusSnapshot: PosterSnapshot | null; + isGenerating?: boolean; + isGenerateError?: boolean; + onTemplateChange: (template: PosterTemplate) => void; + onGenerate: () => void; + onCopyQrCode?: (qrCode: string) => void; +} + +const TEMPLATES: ReadonlyArray<{ id: PosterTemplate; nameKey: string; gradient: string }> = [ + { id: 'classic', nameKey: 'poster.template.classic', gradient: 'from-blue-500 to-purple-600' }, + { id: 'modern', nameKey: 'poster.template.modern', gradient: 'from-emerald-500 to-cyan-600' }, + { id: 'minimal', nameKey: 'poster.template.minimal', gradient: 'from-gray-700 to-gray-900' }, +]; + +export function PosterPreview({ + template, + statusSnapshot, + isGenerating = false, + isGenerateError = false, + onTemplateChange, + onGenerate, + onCopyQrCode, +}: PosterPreviewProps) { + const intl = useIntl(); + const isPosterPending = statusSnapshot?.status === 'queued' || statusSnapshot?.status === 'processing'; + const isPosterFailed = statusSnapshot?.status === 'failed' || isGenerateError; + const completedPoster = statusSnapshot?.status === 'completed' || (!statusSnapshot?.jobId && statusSnapshot?.posterUrl) ? statusSnapshot : null; + const previewUrl = completedPoster?.posterUrl ?? null; + const qrCode = completedPoster?.qrCode ?? null; + const expiresAt = completedPoster?.expiresAt ?? null; + const activeGradient = TEMPLATES.find((item) => item.id === template)?.gradient ?? 'from-blue-500 to-purple-600'; + + return ( +
+
+ {TEMPLATES.map((item) => ( + + ))} +
+ + + + {statusSnapshot && isPosterPending && ( +
+
+
+

+ +

+

+ +

+
+

{statusSnapshot.progress ?? 0}%

+
+
+
+
+
+ )} + + {isPosterFailed && ( +
+ +
+ )} + + {previewUrl && qrCode && expiresAt && ( +
+

+ +

+
+ {intl.formatMessage({ +
+
+ + + +
+

+ +

+
+ )} +
+ ); +} diff --git a/apps/web/src/components/ReviewFlow.test.tsx b/apps/web/src/components/ReviewFlow.test.tsx new file mode 100644 index 0000000..3c89e79 --- /dev/null +++ b/apps/web/src/components/ReviewFlow.test.tsx @@ -0,0 +1,260 @@ +import { describe, expect, it, vi } from 'vitest'; +import { screen } from '@testing-library/react'; +import { renderWithProviders } from '@/test/renderWithProviders'; +import { ReviewFlow } from './ReviewFlow'; + +describe('ReviewFlow', () => { + it('renders start form and disables submit without plan id', () => { + renderWithProviders( + , + ); + + expect(screen.getByRole('region', { name: '发起方案审核' })).toBeInTheDocument(); + expect(screen.getByRole('button', { name: '提交审核' })).toBeDisabled(); + }); + + it('renders start form with English labels', () => { + renderWithProviders( + , + { locale: 'en-US' }, + ); + + expect(screen.getByRole('region', { name: 'Start plan review' })).toBeInTheDocument(); + expect(screen.getByRole('button', { name: 'Submit review' })).toBeDisabled(); + }); + + it('emits plan id changes and start action', async () => { + const handlePlanIdChange = vi.fn(); + const handleStart = vi.fn(); + const { user } = renderWithProviders( + , + ); + + await user.type(screen.getByLabelText('方案 ID'), 'A'); + await user.click(screen.getByRole('button', { name: '提交审核' })); + + expect(handlePlanIdChange).toHaveBeenCalledWith('plan-001A'); + expect(handleStart).toHaveBeenCalledOnce(); + }); + + it('renders safe start failure copy without backend details', () => { + renderWithProviders( + , + { locale: 'en-US' }, + ); + + expect(screen.getByRole('alert')).toHaveTextContent('Unable to start the review. Check the plan ID and try again.'); + expect(screen.queryByText(/raw backend/i)).not.toBeInTheDocument(); + }); + + it('renders status loading and safe refresh failure states', () => { + renderWithProviders( + , + { locale: 'en-US' }, + ); + + expect(screen.getByRole('region', { name: 'Review status panel' })).toHaveTextContent('Loading review status...'); + expect(screen.getByRole('alert')).toHaveTextContent('Unable to refresh review status. The latest known state may be outdated.'); + }); + + it('renders status and LLM progress', () => { + renderWithProviders( + , + ); + + expect(screen.getByRole('region', { name: '审核状态面板' })).toHaveTextContent('审核中'); + expect(screen.getByRole('region', { name: 'LLM 增强面板' })).toBeInTheDocument(); + expect(screen.getByRole('progressbar', { name: 'LLM 增强进度' })).toHaveAttribute('aria-valuenow', '60'); + expect(screen.getByText('生成风险建议')).toBeInTheDocument(); + }); + + it('renders status and LLM progress with English chrome labels', () => { + renderWithProviders( + , + { locale: 'en-US' }, + ); + + expect(screen.getByRole('region', { name: 'Review status panel' })).toHaveTextContent('In review'); + expect(screen.getByRole('region', { name: 'LLM enhancement panel' })).toBeInTheDocument(); + expect(screen.getByRole('progressbar', { name: 'LLM enhancement progress' })).toHaveAttribute('aria-valuenow', '60'); + }); + + it('requires comment for reject and request changes actions', async () => { + const handleCommentChange = vi.fn(); + const handleAction = vi.fn(); + const { user } = renderWithProviders( + , + ); + + expect(screen.getByRole('button', { name: '需修改' })).toBeDisabled(); + expect(screen.getByRole('button', { name: '驳回' })).toBeDisabled(); + + await user.type(screen.getByLabelText('审核意见（驳回 / 需修改时必填）'), '需要补充材料'); + await user.click(screen.getByRole('button', { name: '通过' })); + + expect(handleCommentChange).toHaveBeenCalledWith('需'); + expect(handleAction).toHaveBeenCalledWith('approve'); + }); + + it('renders action controls with English labels', async () => { + const handleCommentChange = vi.fn(); + const handleAction = vi.fn(); + const { user } = renderWithProviders( + , + { locale: 'en-US' }, + ); + + expect(screen.getByRole('region', { name: 'Review actions' })).toBeInTheDocument(); + await user.click(screen.getByRole('button', { name: 'Request changes' })); + + expect(handleAction).toHaveBeenCalledWith('request_changes'); + }); + + it('renders safe action failure copy without backend details', () => { + renderWithProviders( + , + { locale: 'en-US' }, + ); + + expect(screen.getByRole('alert')).toHaveTextContent('Unable to submit this review action. Please try again.'); + expect(screen.queryByText(/stack trace/i)).not.toBeInTheDocument(); + }); +}); diff --git a/apps/web/src/components/ReviewFlow.tsx b/apps/web/src/components/ReviewFlow.tsx new file mode 100644 index 0000000..b175bdc --- /dev/null +++ b/apps/web/src/components/ReviewFlow.tsx @@ -0,0 +1,183 @@ +import { AlertCircle, CheckCircle, ShieldCheck, XCircle } from 'lucide-react'; +import { FormattedMessage, useIntl } from 'react-intl'; +import type { AuditEnhanceStatusResponse } from '@/hooks/useLLMEnhanceMutation'; +import type { ReviewActionInput, ReviewStatusResponse } from '@/hooks/useReviewFlow'; +import { LLMEnhancement } from '@/components/LLMEnhancement'; + +type ReviewActionType = ReviewActionInput['action']; +type ReviewStatus = ReviewStatusResponse['status']; + +const STATUS_META: Record = { + pending: { labelKey: 'reviewFlow.status.pending', icon: AlertCircle, color: 'text-yellow-500' }, + in_progress: { labelKey: 'reviewFlow.status.inProgress', icon: ShieldCheck, color: 'text-blue-500' }, + approved: { labelKey: 'reviewFlow.status.approved', icon: CheckCircle, color: 'text-green-500' }, + rejected: { labelKey: 'reviewFlow.status.rejected', icon: XCircle, color: 'text-red-500' }, + changes_requested: { labelKey: 'reviewFlow.status.changesRequested', icon: AlertCircle, color: 'text-orange-500' }, +}; + +interface ReviewFlowProps { + planId: string; + reviewId: string | null; + comment: string; + status?: ReviewStatusResponse; + enhanceStatus?: AuditEnhanceStatusResponse; + isStarting?: boolean; + isStartError?: boolean; + isStatusLoading?: boolean; + isStatusError?: boolean; + isActing?: boolean; + isActionError?: boolean; + onPlanIdChange: (planId: string) => void; + onCommentChange: (comment: string) => void; + onStart: () => void; + onAction: (action: ReviewActionType) => void; +} + +export function ReviewFlow({ + planId, + reviewId, + comment, + status, + enhanceStatus, + isStarting = false, + isStartError = false, + isStatusLoading = false, + isStatusError = false, + isActing = false, + isActionError = false, + onPlanIdChange, + onCommentChange, + onStart, + onAction, +}: ReviewFlowProps) { + const intl = useIntl(); + + if (!reviewId) { + return ( +
+ + + {isStartError && ( +
+ +
+ )} +
+ ); + } + + const canAct = status?.status === 'pending' || status?.status === 'in_progress'; + + return ( +
+ {isStatusLoading && !status && ( +
+ +
+ )} + + {isStatusError && ( +
+ +
+ )} + + {status && ( +
+
+ {(() => { + const Icon = STATUS_META[status.status].icon; + return
+ {status.comment &&

{status.comment}

} +
+ )} + + {enhanceStatus && ( + + )} + + {canAct && ( +
+